Yes, but this is the diff that is going to happen if it's merged, so it's what r... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

mkozlows on Jan 22, 2015 | parent | context | favorite | on: A better pull request

Yes, but this is the diff that is going to happen if it's merged, so it's what reviewers should be looking at.

taeric on Jan 22, 2015 [–]

I disagree still. Fundamentally, I agree that it is important. I'd go further and say that these two diffs should be similar. If they are dissimilar, then there should be a red flag.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact